fix: Handle exception closing stream for unavailable adapter on windows. #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hdarkly/cpp-sdks into rlamb/sc-251111/stream-close-crash
kinyoklion
commented
Jul 24, 2024
| @@ -341,13 +341,21 @@ class FoxyClient : public Client, | |||
| // If any backoff is taking place, cancel that as well. | |||
| backoff_timer_.cancel(); | |||
There was a problem hiding this comment.
This function can theoretically throw as well, but I cannot find any confirmation of a condition where it actually throws.
keelerm84
approved these changes
Jul 25, 2024
Merged
kinyoklion
pushed a commit
that referenced
this pull request
Jul 25, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-cpp-client: 3.6.3</summary> ## [3.6.3](launchdarkly-cpp-client-v3.6.2...launchdarkly-cpp-client-v3.6.3) (2024-07-25) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-sse-client bumped from 0.5.1 to 0.5.2 </details> <details><summary>launchdarkly-cpp-server: 3.5.3</summary> ## [3.5.3](launchdarkly-cpp-server-v3.5.2...launchdarkly-cpp-server-v3.5.3) (2024-07-25) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-sse-client bumped from 0.5.1 to 0.5.2 </details> <details><summary>launchdarkly-cpp-server-redis-source: 2.1.11</summary> ## [2.1.11](launchdarkly-cpp-server-redis-source-v2.1.10...launchdarkly-cpp-server-redis-source-v2.1.11) (2024-07-25) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-server bumped from 3.5.2 to 3.5.3 </details> <details><summary>launchdarkly-cpp-sse-client: 0.5.2</summary> ## [0.5.2](launchdarkly-cpp-sse-client-v0.5.1...launchdarkly-cpp-sse-client-v0.5.2) (2024-07-25) ### Bug Fixes * Handle exception closing stream for unavailable adapter on windows. ([#427](#427)) ([ae0013c](ae0013c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows shutting down a stream for an adapter that is no longer available would crash. I was testing this by disabling adapters, but my suspicion is after a computer sleeps it may take some time for the adapters to recover on windows.